Drive-bys
http://codereview.chromium.org/3462005/diff/1/4 File src/runtime.cc (right): http://codereview.chromium.org/3462005/diff/1/4#newcode671 src/runtime.cc:671: elms->set(ENUMERABLE_INDEX, Heap::true_value()); I am not sure all intercepted elements are enumerable. You might prefer to use query to find out precise attributes. http://codereview.chromium.org/3462005/diff/1/5 File test/cctest/test-api.cc (right): http://codereview.chromium.org/3462005/diff/1/5#newcode3028 test/cctest/test-api.cc:3028: templ->SetIndexedPropertyHandler(IdentityIndexedPropertyGetter); you probably need to extend this test case for cases when there are setters, queries and enumerators are present. But in real life (read, Chromium), we only have getters, so realistically it's not bad a coverage. http://codereview.chromium.org/3462005/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
