Thanks for comments Anton! Of course we can use an interceptor query (if it is present) to determine specific properties of intercepted properties.
But mapping from this properties to property descriptor (especially if interceptor query is not defined) is somewhat unclear to me. Because interceptors are implementation detail not a part of ECMAScript 5. That's why I took a liberty of returning the "default" property descriptor. The same semantic ambiguity problem holds for external arrays and pixel arrays --- e.g. you cannot say that an index property of a pixel array is "configurable". I will try to improve soundness of this. -- Vyacheslav Egorov On Wed, Sep 22, 2010 at 3:26 PM, <[email protected]> wrote: > Drive-bys > > > http://codereview.chromium.org/3462005/diff/1/4 > File src/runtime.cc (right): > > http://codereview.chromium.org/3462005/diff/1/4#newcode671 > src/runtime.cc:671: elms->set(ENUMERABLE_INDEX, Heap::true_value()); > I am not sure all intercepted elements are enumerable. You might prefer > to use query to find out precise attributes. > > http://codereview.chromium.org/3462005/diff/1/5 > File test/cctest/test-api.cc (right): > > http://codereview.chromium.org/3462005/diff/1/5#newcode3028 > test/cctest/test-api.cc:3028: > templ->SetIndexedPropertyHandler(IdentityIndexedPropertyGetter); > you probably need to extend this test case for cases when there are > setters, queries and enumerators are present. But in real life (read, > Chromium), we only have getters, so realistically it's not bad a > coverage. > > http://codereview.chromium.org/3462005/show > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
