LGTM
http://codereview.chromium.org/3467010/diff/9001/10001 File src/SConscript (right): http://codereview.chromium.org/3467010/diff/9001/10001#newcode103 src/SConscript:103: string-search.cc What about xcode and MSVC? http://codereview.chromium.org/3467010/diff/9001/10003 File src/string-search.h (right): http://codereview.chromium.org/3467010/diff/9001/10003#newcode85 src/string-search.h:85: // Table used temporarily while building the BoyerMoore goodsuffix goodsuffix -> good suffix http://codereview.chromium.org/3467010/diff/9001/10003#newcode121 src/string-search.h:121: // ASCII Needle; Needle -> needle and below. http://codereview.chromium.org/3467010/diff/9001/10003#newcode353 src/string-search.h:353: Double space here and lots of other places. http://codereview.chromium.org/3467010/diff/9001/10003#newcode415 src/string-search.h:415: strategy_ = &BoyerMooreSearch; This is non-intuitive. The name of this function doesn't suggest that the strategy is changed when the tables are calculated. I think this should be done explicitly at the points where the Populate... method is called. http://codereview.chromium.org/3467010/diff/9001/10003#newcode498 src/string-search.h:498: strategy_ = &BoyerMooreHorspoolSearch; And here. http://codereview.chromium.org/3467010/diff/9001/10003#newcode559 src/string-search.h:559: // object should only be constructed once and then called multiple times. Is this comment accurate? It seems like the fields and methods are all static. Is an object being created? http://codereview.chromium.org/3467010/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
