http://codereview.chromium.org/3467010/diff/9001/10001 File src/SConscript (right):
http://codereview.chromium.org/3467010/diff/9001/10001#newcode103 src/SConscript:103: string-search.cc I added the files to the visual-studio projects. I see no way to manually edit the xcode project. http://codereview.chromium.org/3467010/diff/9001/10003 File src/string-search.h (right): http://codereview.chromium.org/3467010/diff/9001/10003#newcode85 src/string-search.h:85: // Table used temporarily while building the BoyerMoore goodsuffix On 2010/09/28 13:16:49, Erik Corry wrote:
goodsuffix -> good suffix
Done. http://codereview.chromium.org/3467010/diff/9001/10003#newcode121 src/string-search.h:121: // ASCII Needle; On 2010/09/28 13:16:49, Erik Corry wrote:
Needle -> needle and below.
Done. http://codereview.chromium.org/3467010/diff/9001/10003#newcode353 src/string-search.h:353: Done. http://codereview.chromium.org/3467010/diff/9001/10003#newcode415 src/string-search.h:415: strategy_ = &BoyerMooreSearch; Moved to just after the call to Populate... http://codereview.chromium.org/3467010/diff/9001/10003#newcode498 src/string-search.h:498: strategy_ = &BoyerMooreHorspoolSearch; Too. http://codereview.chromium.org/3467010/diff/9001/10003#newcode559 src/string-search.h:559: // object should only be constructed once and then called multiple times. The Search function isn't static, nor are the pattern_ and strategy_ fields. An object should be created. Rewording the comment to be more clear. http://codereview.chromium.org/3467010/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
