Revision: 5547 Author: [email protected] Date: Tue Sep 28 07:49:29 2010 Log: Fix external array iteration used in array concat.
We should use Factory and not Heap there. Review URL: http://codereview.chromium.org/3380031 http://code.google.com/p/v8/source/detail?r=5547 Modified: /branches/bleeding_edge/src/runtime.cc ======================================= --- /branches/bleeding_edge/src/runtime.cc Tue Sep 28 05:49:25 2010 +++ /branches/bleeding_edge/src/runtime.cc Tue Sep 28 07:49:29 2010 @@ -7253,15 +7253,15 @@ Handle<Smi> e(Smi::FromInt(static_cast<int>(val))); visitor->visit(j, e); } else { - Handle<Object> e( - Heap::AllocateHeapNumber(static_cast<ElementType>(val))); + Handle<Object> e = + Factory::NewNumber(static_cast<ElementType>(val)); visitor->visit(j, e); } } } } else { for (uint32_t j = 0; j < len; j++) { - Handle<Object> e(Heap::AllocateHeapNumber(array->get(j))); + Handle<Object> e = Factory::NewNumber(array->get(j)); visitor->visit(j, e); } } -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
