Reviewers: Vyacheslav Egorov,
Description:
Fix external array iteration used in array concat.
We should use Factory and not Heap there.
Please review this at http://codereview.chromium.org/3380031/show
Affected files:
M src/runtime.cc
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index
8d58db74a017a357d005a22818716976c2e9e5c6..dd922ed8cd6dee1e687f5e2584a7b84e4dd88469
100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -7253,15 +7253,15 @@ static uint32_t
IterateExternalArrayElements(Handle<JSObject> receiver,
Handle<Smi> e(Smi::FromInt(static_cast<int>(val)));
visitor->visit(j, e);
} else {
- Handle<Object> e(
- Heap::AllocateHeapNumber(static_cast<ElementType>(val)));
+ Handle<Object> e =
+ Factory::NewNumber(static_cast<ElementType>(val));
visitor->visit(j, e);
}
}
}
} else {
for (uint32_t j = 0; j < len; j++) {
- Handle<Object> e(Heap::AllocateHeapNumber(array->get(j)));
+ Handle<Object> e = Factory::NewNumber(array->get(j));
visitor->visit(j, e);
}
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
