LGTM
http://codereview.chromium.org/3601010/diff/1/2 File samples/shell.cc (right): http://codereview.chromium.org/3601010/diff/1/2#newcode98 samples/shell.cc:98: if (!ExecuteString(source, file_name, false, true)) { This code can be extracted out of the if/else expression. http://codereview.chromium.org/3601010/diff/1/2#newcode145 samples/shell.cc:145: void* IsolateThreadEntry(void* arg) { This function can be made a private static method on SourceGroup. http://codereview.chromium.org/3601010/diff/1/2#newcode190 samples/shell.cc:190: } Should we delete isolate_sources before exit here? http://codereview.chromium.org/3601010/diff/1/9 File tools/statics.whitelist (right): http://codereview.chromium.org/3601010/diff/1/9#newcode3 tools/statics.whitelist:3: .*\.bss.*guard variable for v8::internal::MemCopy.* are you sure you want to commit this? http://codereview.chromium.org/3601010/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
