On 2010/10/21 07:28:21, Mads Ager wrote:
http://codereview.chromium.org/3973002/diff/1/2
File src/flag-definitions.h (right):
http://codereview.chromium.org/3973002/diff/1/2#newcode143
src/flag-definitions.h:143: DEFINE_bool(disable_jit_cookie,
false, "jit_cookie
always set to NULL")
Can we change the name to split_constants_with_cookie or something more
descriptive like that (which means changing the default to true as well).
Sounds reasonable. Although I think I'd prefer mask_constants_with_cookie if
you're okay with that?
http://codereview.chromium.org/3973002/diff/1/4
File src/ia32/codegen-ia32.h (right):
http://codereview.chromium.org/3973002/diff/1/4#newcode790
src/ia32/codegen-ia32.h:790: // initializes this to NULL causing it to
have no
effect
NULL -> 0
Dumb oversight on my part. I'll fix that before resubmitting.
http://codereview.chromium.org/3973002/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
