Committed as revision 5734. On 2010/10/29 06:06:17, Mads Ager wrote:
LGTM
I'll take care of these nits and land it for you. Thanks!
http://codereview.chromium.org/3973002/diff/17001/18001 File src/flag-definitions.h (right):
http://codereview.chromium.org/3973002/diff/17001/18001#newcode143 src/flag-definitions.h:143: DEFINE_bool(mask_constants_with_cookie, false, "jit_cookie always set to NULL") Shouldn't this be true now and the description updated?
http://codereview.chromium.org/3973002/diff/17001/18002 File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/3973002/diff/17001/18002#newcode157src/ia32/codegen-ia32.cc:157: jit_cookie_((FLAG_mask_constants_with_cookie) ?
0
: V8::Random()) {
Flip 0 and V8:Random (after making the flag true by default)?
http://codereview.chromium.org/3973002/diff/17001/18003 File src/ia32/codegen-ia32.h (right):
http://codereview.chromium.org/3973002/diff/17001/18003#newcode789src/ia32/codegen-ia32.h:789: // switch --disable_jit_cookie initializes this
to
0 causing it to have no You changed the flag?
http://codereview.chromium.org/3973002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
