http://codereview.chromium.org/4295003/diff/1/4 File src/arm/simulator-arm.cc (right):
http://codereview.chromium.org/4295003/diff/1/4#newcode2643 src/arm/simulator-arm.cc:2643: uint32_t mode; Please use the enum type here. This communicates exactly what values are expected for this variable. http://codereview.chromium.org/4295003/diff/1/5 File src/arm/simulator-arm.h (right): http://codereview.chromium.org/4295003/diff/1/5#newcode314 src/arm/simulator-arm.h:314: }; Why isn't this enum in constants-arm.h? http://codereview.chromium.org/4295003/diff/1/5#newcode315 src/arm/simulator-arm.h:315: uint32_t rounding_mode; Field names end with a _ and I suggest this should be typed as FPSCRRoundingMode. http://codereview.chromium.org/4295003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
