Thanks for the review. The new patch should be uploaded soon.
Alexandre http://codereview.chromium.org/4295003/diff/1/3 File src/arm/assembler-arm.h (right): http://codereview.chromium.org/4295003/diff/1/3#newcode1017 src/arm/assembler-arm.h:1017: ConversionMode mode = RoundToZero); Done. On 2010/11/03 08:19:20, Erik Corry wrote:
All other instructions have the condition as the last argument. I
think we
should stick to that here too.
http://codereview.chromium.org/4295003/diff/1/4 File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/4295003/diff/1/4#newcode2643 src/arm/simulator-arm.cc:2643: uint32_t mode; On 2010/11/03 06:11:04, iposva wrote:
Please use the enum type here. This communicates exactly what values
are
expected for this variable.
Done. http://codereview.chromium.org/4295003/diff/1/5 File src/arm/simulator-arm.h (right): http://codereview.chromium.org/4295003/diff/1/5#newcode314 src/arm/simulator-arm.h:314: }; It should be. Moved. On 2010/11/03 06:11:04, iposva wrote:
Why isn't this enum in constants-arm.h?
http://codereview.chromium.org/4295003/diff/1/5#newcode315 src/arm/simulator-arm.h:315: uint32_t rounding_mode; On 2010/11/03 06:11:04, iposva wrote:
Field names end with a _ and I suggest this should be typed as FPSCRRoundingMode.
Renamed rounding_mode to FPSCR_rounding_mode_. Fields use lower case with underscore and finish with an underscore. http://codereview.chromium.org/4295003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
