LGTM

http://codereview.chromium.org/4295004/diff/1/5
File src/heap.cc (right):

http://codereview.chromium.org/4295004/diff/1/5#newcode436
src/heap.cc:436: MarkCompactCollector::SetForceCompaction(true);
do we really want to get tons of compactions here?

http://codereview.chromium.org/4295004/diff/1/5#newcode469
src/heap.cc:469: bool next_gc_could_collect_more = false;
could -> can?

http://codereview.chromium.org/4295004/diff/1/6
File src/heap.h (right):

http://codereview.chromium.org/4295004/diff/1/6#newcode1258
src/heap.h:1258: // Returns whether there is a chance another major GC
could
is a change _that_ another ?

http://codereview.chromium.org/4295004/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to