Thank you very much---that was really educating (no kidding) :)
Submitting http://codereview.chromium.org/4295004/diff/1/5 File src/heap.cc (right): http://codereview.chromium.org/4295004/diff/1/5#newcode436 src/heap.cc:436: MarkCompactCollector::SetForceCompaction(true); On 2010/11/03 12:06:17, Vyacheslav Egorov wrote:
do we really want to get tons of compactions here?
Discussed offline---as should be an exceptional path, let's do the best we can. http://codereview.chromium.org/4295004/diff/1/5#newcode469 src/heap.cc:469: bool next_gc_could_collect_more = false; On 2010/11/03 12:06:17, Vyacheslav Egorov wrote:
could -> can?
And another 'cannot help': http://www.merriam-webster.com/dictionary/could http://oxforddictionaries.com/view/entry/m_en_gb0183790#m_en_gb0183790 but changed to likely. http://codereview.chromium.org/4295004/diff/1/6 File src/heap.h (right): http://codereview.chromium.org/4295004/diff/1/6#newcode1258 src/heap.h:1258: // Returns whether there is a chance another major GC could On 2010/11/03 12:06:17, Vyacheslav Egorov wrote:
is a change _that_ another ?
Done, but I cannot help quoting the following: Omission of _that_ (conjunction). Though this is strictly speaking not an ellipsis, but rather an exercise of the ancient right to abstain from subordinating a substantival clause[...] Yay! http://books.google.com/books?id=Vr7muDFR6j4C&lpg=PA135&ots=F41-3ydPl0&dq=%22omission%20of%20that%22%20modern%20english&pg=PA135#v=onepage&q&f=false http://codereview.chromium.org/4295004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
