http://codereview.chromium.org/4397004/diff/19001/20001 File include/v8.h (right):
http://codereview.chromium.org/4397004/diff/19001/20001#newcode2497 include/v8.h:2497: total_heap_size_executable_ = size; } '}' on new line. http://codereview.chromium.org/4397004/diff/19001/20003 File src/heap.cc (right): http://codereview.chromium.org/4397004/diff/19001/20003#newcode92 src/heap.cc:92: intptr_t Heap::max_executable_size_ = 128*MB; Do you want the limit to be the same on the 64-bit version? Code objects are usually quite a bit bigger in the 64-bit version. Do we have any data for 64-bit? http://codereview.chromium.org/4397004/diff/19001/20005 File src/spaces.cc (right): http://codereview.chromium.org/4397004/diff/19001/20005#newcode364 src/spaces.cc:364: if (executable == EXECUTABLE) { We should be able to combine this check with the other executable check that we perform already below. This adds an extra check for all allocations. We can make it extra checks only for executable memory. http://codereview.chromium.org/4397004/diff/19001/20005#newcode366 src/spaces.cc:366: static_cast<size_t>(capacity_executable_)) { Indentation off. http://codereview.chromium.org/4397004/diff/19001/20006 File src/spaces.h (right): http://codereview.chromium.org/4397004/diff/19001/20006#newcode596 src/spaces.h:596: 0 : capacity_executable_ - size_executable_; } Please move '}' to new line. I would prefer: if (capacity_executable_ < size_executable_) return 0; return capacity_executable_ - size_executable_; http://codereview.chromium.org/4397004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
