LGTM, I'll take care of these nits and land.

http://codereview.chromium.org/4397004/diff/42002/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/4397004/diff/42002/src/heap.cc#newcode4348
src/heap.cc:4348: if (max_executable_size > 0)
Let's add braces here.

http://codereview.chromium.org/4397004/diff/42002/src/spaces.cc
File src/spaces.cc (right):

http://codereview.chromium.org/4397004/diff/42002/src/spaces.cc#newcode369
src/spaces.cc:369: "V8 Executable Allocation capacity exceeded"));
Indentation off by one space it seems?

http://codereview.chromium.org/4397004/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to