LGTM
http://codereview.chromium.org/5161002/diff/1/src/arm/codegen-arm.cc File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/5161002/diff/1/src/arm/codegen-arm.cc#newcode4358 src/arm/codegen-arm.cc:4358: // a stack image common for calls using an IC (receiver followed by Swap the ... to follow the calling convention for call ICs? In all the other code generators as well. http://codereview.chromium.org/5161002/diff/1/src/ia32/codegen-ia32.cc File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/5161002/diff/1/src/ia32/codegen-ia32.cc#newcode6303 src/ia32/codegen-ia32.cc:6303: Result tmp1 = frame_->Pop(); Use names like 'key' and 'receiver' instead of tmp1 and tmp2? http://codereview.chromium.org/5161002/diff/1/src/x64/codegen-x64.cc File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/5161002/diff/1/src/x64/codegen-x64.cc#newcode5601 src/x64/codegen-x64.cc:5601: Result tmp1 = frame_->Pop(); names? http://codereview.chromium.org/5161002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
