http://codereview.chromium.org/5161002/diff/1/src/arm/codegen-arm.cc File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/5161002/diff/1/src/arm/codegen-arm.cc#newcode4358 src/arm/codegen-arm.cc:4358: // a stack image common for calls using an IC (receiver followed by On 2010/11/17 13:11:37, Mads Ager wrote:
Swap the ... to follow the calling convention for call ICs?
In all the other code generators as well.
Done. http://codereview.chromium.org/5161002/diff/1/src/ia32/codegen-ia32.cc File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/5161002/diff/1/src/ia32/codegen-ia32.cc#newcode6303 src/ia32/codegen-ia32.cc:6303: Result tmp1 = frame_->Pop(); On 2010/11/17 13:11:37, Mads Ager wrote:
Use names like 'key' and 'receiver' instead of tmp1 and tmp2?
Done. http://codereview.chromium.org/5161002/diff/1/src/x64/codegen-x64.cc File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/5161002/diff/1/src/x64/codegen-x64.cc#newcode5601 src/x64/codegen-x64.cc:5601: Result tmp1 = frame_->Pop(); On 2010/11/17 13:11:37, Mads Ager wrote:
names?
Done. http://codereview.chromium.org/5161002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
