LGTM with comments
http://codereview.chromium.org/5100002/diff/3001/src/handles.cc File src/handles.cc (right): http://codereview.chromium.org/5100002/diff/3001/src/handles.cc#newcode509 src/handles.cc:509: Handle<FixedArray> CalculateLineEnds(Vector<const SourceChar> src, Please mark this private function 'static'. http://codereview.chromium.org/5100002/diff/3001/src/handles.cc#newcode554 src/handles.cc:554: if (seq_src->IsConsString()) seq_src = ConsString::cast(seq_src)->first(); Should you assert anything about the second part of cons string? Must it be empty or something? http://codereview.chromium.org/5100002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
