http://codereview.chromium.org/5100002/diff/3001/src/handles.cc File src/handles.cc (right):
http://codereview.chromium.org/5100002/diff/3001/src/handles.cc#newcode509 src/handles.cc:509: Handle<FixedArray> CalculateLineEnds(Vector<const SourceChar> src, On 2010/11/17 15:32:00, Michail Naganov wrote:
Please mark this private function 'static'.
Done. http://codereview.chromium.org/5100002/diff/3001/src/handles.cc#newcode554 src/handles.cc:554: if (seq_src->IsConsString()) seq_src = ConsString::cast(seq_src)->first(); On 2010/11/17 15:32:00, Michail Naganov wrote:
Should you assert anything about the second part of cons string? Must
it be
empty or something?
Yes. src is flat so if it is a cons string then the second part must be empty. http://codereview.chromium.org/5100002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
