Quick drive by.
http://codereview.chromium.org/5640004/diff/10001/src/assembler.cc File src/assembler.cc (right): http://codereview.chromium.org/5640004/diff/10001/src/assembler.cc#newcode881 src/assembler.cc:881: case Token::BIT_XOR: Don't repurpose these tokens this way, it's a bug waiting to happen. Introduce an enumeration in ExternalReference for the operation (and a function to convert token to operation for the one call site in ARM that needs it). http://codereview.chromium.org/5640004/diff/10001/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/5640004/diff/10001/src/hydrogen.cc#newcode4108 src/hydrogen.cc:4108: PushAndAdd(graph_->GetConstant1()-> I don't understand why you push this on the bailout environment. http://codereview.chromium.org/5640004/diff/10001/src/hydrogen.cc#newcode4109 src/hydrogen.cc:4109: CopyToRepresentation(Representation::Double())); This seems too roundabout. Is there a reason not to write the more straightforward: AddInstruction(new HConstant(Handle<Object>(Smi::FromInt(1)), Representation::Double())); (or whatever it takes to typecheck)? http://codereview.chromium.org/5640004/diff/10001/src/hydrogen.cc#newcode4110 src/hydrogen.cc:4110: PushAndAdd(new HUnaryMathOperation(left, kMathPowHalf)); Nor this. http://codereview.chromium.org/5640004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
