http://codereview.chromium.org/5640004/diff/24001/src/assembler.cc File src/assembler.cc (right):
http://codereview.chromium.org/5640004/diff/24001/src/assembler.cc#newcode808 src/assembler.cc:808: double m = (y < 0) ? 1/x : x; On 2010/12/08 14:09:27, fschneider1 wrote:
--> 1 / x
Done. http://codereview.chromium.org/5640004/diff/24001/src/ia32/lithium-ia32.cc File src/ia32/lithium-ia32.cc (right): http://codereview.chromium.org/5640004/diff/24001/src/ia32/lithium-ia32.cc#newcode1578 src/ia32/lithium-ia32.cc:1578: // Abort("Tagged expoinent in Math.pow not yet workign."); On 2010/12/08 14:09:27, fschneider1 wrote:
Remove commented code?
Done. http://codereview.chromium.org/5640004/diff/24001/src/ia32/lithium-ia32.cc#newcode1586 src/ia32/lithium-ia32.cc:1586: return MarkAsCall(DefineFixedDouble(result, xmm1), instr); On 2010/12/08 14:09:27, fschneider1 wrote:
In case of a tagged exponent you need to pass CAN_DEOPTIMIZE_EAGERLY
to
MarkAsCall.
Done. http://codereview.chromium.org/5640004/diff/24001/src/ia32/lithium-ia32.h File src/ia32/lithium-ia32.h (right): http://codereview.chromium.org/5640004/diff/24001/src/ia32/lithium-ia32.h#newcode144 src/ia32/lithium-ia32.h:144: // LUnknownOSRValue On 2010/12/08 14:09:27, fschneider1 wrote:
Accidental edit? UnknownOSRValue is not a UnaryOperation.
Done. http://codereview.chromium.org/5640004/diff/24001/src/ia32/lithium-ia32.h#newcode233 src/ia32/lithium-ia32.h:233: V(Power) \ On 2010/12/08 14:09:27, fschneider1 wrote:
Align \
Done. http://codereview.chromium.org/5640004/diff/24001/src/ia32/lithium-ia32.h#newcode1165 src/ia32/lithium-ia32.h:1165: Representation exponent_type() { return exponent_type_; } On 2010/12/08 14:09:27, fschneider1 wrote:
You can save the exponent_type_ member here and get the representation
of the
expononent from the H-instruction via the hydrogen()-accessor
return hydrogen()->right()->representation()
and by declaring:
DECLARE_HYDROGEN_ACCESSOR(Power)
Done. http://codereview.chromium.org/5640004/diff/24001/src/ia32/lithium-ia32.h#newcode1165 src/ia32/lithium-ia32.h:1165: Representation exponent_type() { return exponent_type_; } On 2010/12/08 14:09:27, fschneider1 wrote:
You can save the exponent_type_ member here and get the representation
of the
expononent from the H-instruction via the hydrogen()-accessor
return hydrogen()->right()->representation()
and by declaring:
DECLARE_HYDROGEN_ACCESSOR(Power)
Done. http://codereview.chromium.org/5640004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
