http://codereview.chromium.org/5701001/diff/1/build/common.gypi File build/common.gypi (right):
http://codereview.chromium.org/5701001/diff/1/build/common.gypi#newcode56 build/common.gypi:56: },{'target_defaults': {'ccflags':['-xxx']}}], I'd rewrite this line as }, { # else: not linux 'target_defaults': {'ccflags':['-xxx']} }], http://codereview.chromium.org/5701001/diff/1/tools/gyp/samples.gyp File tools/gyp/samples.gyp (right): http://codereview.chromium.org/5701001/diff/1/tools/gyp/samples.gyp#newcode44 tools/gyp/samples.gyp:44: # This could be gotten by not setting chromium_code, if that's OK. We normally only set chromium_code for code that is in the chromium tree. Since v8 better knows its build settings, I think it can leave chromium_code at 0. http://codereview.chromium.org/5701001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
