LGTM Sorry for popping up, I just happened to work on this part of the code.
http://codereview.chromium.org/5699003/diff/2001/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/5699003/diff/2001/src/ia32/macro-assembler-ia32.cc#newcode1225 src/ia32/macro-assembler-ia32.cc:1225: #if defined(USING_BSD_ABI) || defined(__MINGW32__) I'd rather moved defined(__MINGW32__) into src/globals.h where USING_BSD_ABI is defined http://codereview.chromium.org/5699003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
