http://codereview.chromium.org/5714001/diff/9001/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right):
http://codereview.chromium.org/5714001/diff/9001/src/ia32/full-codegen-ia32.cc#newcode1597 src/ia32/full-codegen-ia32.cc:1597: __ CallStub(&stub); I like Vitaly's idea because it's safer. I think the jumping/branching and the calling is something you want to see in this code generator code. The required __nop() or EmitPatchInfo is bookkeeping and doesn't need to be seen here. Taking it a step further, you could make it read more like a jump by making the interface: JumpPatchSite patch_site(masm_); patch_site.EmitJump(not_zero, &call_stub); ... EmitCallStub(&stub, &patch_site); http://codereview.chromium.org/5714001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
