Still LGTM.
http://codereview.chromium.org/5714001/diff/30001/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): http://codereview.chromium.org/5714001/diff/30001/src/ia32/full-codegen-ia32.cc#newcode47 src/ia32/full-codegen-ia32.cc:47: JumpPatchSite(MacroAssembler* masm) : masm_(masm), info_emitted_(false) { } Missing "explicit". http://codereview.chromium.org/5714001/diff/30001/src/ia32/full-codegen-ia32.cc#newcode66 src/ia32/full-codegen-ia32.cc:66: bool is_bound() { return patch_site_.is_bound(); } Can it be made const? http://codereview.chromium.org/5714001/diff/30001/src/ia32/full-codegen-ia32.cc#newcode71 src/ia32/full-codegen-ia32.cc:71: bool info_emitted_; Should probably be guarded by #ifdef DEBUG. http://codereview.chromium.org/5714001/diff/30001/src/ia32/full-codegen-ia32.cc#newcode1891 src/ia32/full-codegen-ia32.cc:1891: __ CallStub(&stub); How about making patch site an optional parameter to EmitCallIC so that you can use EmitCallIC(&stub, NULL) in cases like this to get the nop generated? http://codereview.chromium.org/5714001/diff/30001/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/5714001/diff/30001/src/ia32/lithium-codegen-ia32.cc#newcode1093 src/ia32/lithium-codegen-ia32.cc:1093: __ nop(); // Signals no inlined smi code. You can make CallCode emit the nop, if the code is a binary IC stub. http://codereview.chromium.org/5714001/diff/30001/src/ic.cc File src/ic.cc (right): http://codereview.chromium.org/5714001/diff/30001/src/ic.cc#newcode2135 src/ic.cc:2135: CompareIC::State CompareIC::TargetState(State state, Handle<Object> x, Handle<Object> y) { Line too long. http://codereview.chromium.org/5714001/diff/30001/src/type-info.cc File src/type-info.cc (right): http://codereview.chromium.org/5714001/diff/30001/src/type-info.cc#newcode144 src/type-info.cc:144: case CompareIC::UNINITIALIZED: Return unknown? http://codereview.chromium.org/5714001/diff/30001/src/type-info.cc#newcode228 src/type-info.cc:228: case CompareIC::UNINITIALIZED: Same here. http://codereview.chromium.org/5714001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
