LGTM
http://codereview.chromium.org/5773002/diff/1/src/v8natives.js File src/v8natives.js (right): http://codereview.chromium.org/5773002/diff/1/src/v8natives.js#newcode618 src/v8natives.js:618: var value = Maybe add a comment that states that this actually works even when no existing value is present (since it defaults to undefined) - even when this is an accessor. http://codereview.chromium.org/5773002/diff/1/test/mjsunit/object-define-property.js File test/mjsunit/object-define-property.js (right): http://codereview.chromium.org/5773002/diff/1/test/mjsunit/object-define-property.js#newcode880 test/mjsunit/object-define-property.js:880: Maybe add an additional test that makes sure that an accessor is actually overwritten correctly (step 9.c) if we only set the writable flag http://codereview.chromium.org/5773002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
