Drive by.
http://codereview.chromium.org/5773002/diff/1/src/v8natives.js File src/v8natives.js (right): http://codereview.chromium.org/5773002/diff/1/src/v8natives.js#newcode618 src/v8natives.js:618: var value = I would actually suggest writing it just like the rest of the code in this function: if (desc.hasValue()) { ... } else if (!IS_UNDEFINED(current)) { ... } else { ... }. There's no need for such a comment if you make the code clear and explicit instead. (It's especially surprising because it differs from all the surrounding code, forcing the reader to think about it). We will also generate slightly better code for IS_UNDEFINED(current) than using conversion to boolean to test if it's undefined, so there's no reason to be cryptic. http://codereview.chromium.org/5773002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
