LGTM, except that we shouldn't lose the integer power optimization. If
this is
committed, we should check to see if restoring the optimization improves
performance.
http://codereview.chromium.org/5900001/diff/5001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
http://codereview.chromium.org/5900001/diff/5001/src/ia32/lithium-codegen-ia32.cc#newcode2285
src/ia32/lithium-codegen-ia32.cc:2285: __ jmp(&call);
Calling power_double_double rather than power_double_int here loses the
optimization for integer powers, which is much faster in many cases.
Integer powers use multiplication and squaring, and double powers use
log and exp.
http://codereview.chromium.org/5900001/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
