Comitted as is. Let's keep an eye on it. On Wed, Dec 15, 2010 at 3:43 PM, <[email protected]> wrote:
> > > http://codereview.chromium.org/5900001/diff/5001/src/ia32/lithium-codegen-ia32.cc > File src/ia32/lithium-codegen-ia32.cc (right): > > > http://codereview.chromium.org/5900001/diff/5001/src/ia32/lithium-codegen-ia32.cc#newcode2285 > src/ia32/lithium-codegen-ia32.cc:2285: __ jmp(&call); > On 2010/12/15 14:38:38, William Hesse wrote: > >> Calling power_double_double rather than power_double_int here loses >> > the > >> optimization for integer powers, which is much faster in many cases. >> > Integer > >> powers use multiplication and squaring, and double powers use log and >> > exp. > > Good point. I'll check performance. I didn't notice that two different > functions were called here. Thanks! > > > http://codereview.chromium.org/5900001/ > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
