Please take another look.
Thanks, Vitaly http://codereview.chromium.org/5812005/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/5812005/diff/1/src/hydrogen.cc#newcode2577 src/hydrogen.cc:2577: AddSimulate(stmt->tag()->id()); On 2010/12/15 12:10:16, fschneider wrote:
I think that if the stmt->tag() expression has a side effect
VisitForValue will
insert a simulate already, and we should avoid having two simulates
with the
same id.
Maybe we can avoid explicitly calling AddSimulate here, since we would
just
deoptimize to the last instruction that has a side effect.
As discussed by IM an extra simulate is needed here because of dead phi elimination. Added a todo. http://codereview.chromium.org/5812005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
