LGTM.
Maybe we can avoid the problem with OSR by checking all clauses if are able
to
compile them (only SmiLiterals as labels) earlier. See my comment below -
Otherwise lgtm!
http://codereview.chromium.org/5812005/diff/11001/src/hydrogen.cc
File src/hydrogen.cc (right):
http://codereview.chromium.org/5812005/diff/11001/src/hydrogen.cc#newcode2595
src/hydrogen.cc:2595: }
Does it make sense to check if all clauses have a SmiLiteral as the
clause-label before this loop? Otherwise we may optimize a function
where we will unconditionally deoptimize every time.
Maybe this would also avoid the problem with OSR?
http://codereview.chromium.org/5812005/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
