http://codereview.chromium.org/5988003/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/5988003/diff/1/src/arm/code-stubs-arm.cc#newcode2908 src/arm/code-stubs-arm.cc:2908: const Register result = r0; I don't think an alias for the result is required (when it is r0) - just use r0 there. http://codereview.chromium.org/5988003/diff/1/src/arm/code-stubs-arm.cc#newcode2917 src/arm/code-stubs-arm.cc:2917: // and type into scratch How about implementing IsObjectJSObjectType in the ARM macro assembler as well? http://codereview.chromium.org/5988003/diff/1/src/arm/code-stubs-arm.cc#newcode2932 src/arm/code-stubs-arm.cc:2932: if (!args_in_registers()) { Use Drop from the ARM macro assembler to drop two elements from the stack (several times below). http://codereview.chromium.org/5988003/diff/1/src/arm/code-stubs-arm.cc#newcode2935 src/arm/code-stubs-arm.cc:2935: } Use Ret from the ARM macro assembler. I suggest you add a Ret(int drop) function to the ARM macro assembler to combine the Drop() and Ret(). http://codereview.chromium.org/5988003/diff/1/src/arm/code-stubs-arm.cc#newcode2938 src/arm/code-stubs-arm.cc:2938: __ bind(&miss); You should use the register aliases created throughout all the code. http://codereview.chromium.org/5988003/diff/1/src/arm/code-stubs-arm.cc#newcode2988 src/arm/code-stubs-arm.cc:2988: __ tst(function, Operand(kSmiTagMask)); The ARM macro assembler has BranchOnSmi. http://codereview.chromium.org/5988003/diff/1/src/arm/code-stubs-arm.cc#newcode3005 src/arm/code-stubs-arm.cc:3005: __ tst(object, Operand(kSmiTagMask)); The ARM macro assembler has BranchOnNotSmi. http://codereview.chromium.org/5988003/diff/1/src/arm/code-stubs-arm.cc#newcode3015 src/arm/code-stubs-arm.cc:3015: // String values are not instances of anything. Please implement IsObjectStringType in ARM macro assembler. http://codereview.chromium.org/5988003/diff/1/src/arm/code-stubs-arm.cc#newcode3021 src/arm/code-stubs-arm.cc:3021: __ IncrementCounter(&Counters::instance_of_stub_false_string, You can leave out all the counters. Then you don't need scratch2. http://codereview.chromium.org/5988003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
