Some more comments, forgot the last two files.
http://codereview.chromium.org/5988003/diff/1/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): http://codereview.chromium.org/5988003/diff/1/src/arm/lithium-arm.cc#newcode1319 src/arm/lithium-arm.cc:1319: new LInstanceOf(UseFixed(instr->left(), r1), UseFixed(instr->right(), r0)); Long line. http://codereview.chromium.org/5988003/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/5988003/diff/1/src/arm/lithium-codegen-arm.cc#newcode1340 src/arm/lithium-codegen-arm.cc:1340: // we expect object and function in registers r1 and r0. Please start comment with uppercase letter. http://codereview.chromium.org/5988003/diff/1/src/arm/lithium-codegen-arm.cc#newcode1345 src/arm/lithium-codegen-arm.cc:1345: __ tst(r0, r0); I think this can be done with conditional moves and no branching. http://codereview.chromium.org/5988003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
