Thanks!
-- Vitaly http://codereview.chromium.org/6009005/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/6009005/diff/1/src/hydrogen-instructions.h#newcode2640 src/hydrogen-instructions.h:2640: virtual bool DataEquals(HValue* other) const { return true; } On 2010/12/21 17:57:52, fschneider wrote:
I think you can just rely on the implementation the super-class HValue
here. I just wanted to make it explicit that it's required here. I feel safer this way. http://codereview.chromium.org/6009005/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/6009005/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode1860 src/ia32/lithium-codegen-ia32.cc:1860: // simply miss the cache instead. This will allow us to allocate a On 2010/12/21 17:57:52, fschneider wrote:
This comment is not 100% up-to-date, since we deoptimize here and
handle this
case in non-optimized code.
Updated. http://codereview.chromium.org/6009005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
