On Wed, Jan 26, 2011 at 5:21 PM, Kevin Millikin <[email protected]> wrote: > On Wed, Jan 26, 2011 at 3:06 PM, <[email protected]> wrote: >> >> >> http://codereview.chromium.org/6009005/diff/1/src/hydrogen-instructions.h#newcode135 >> src/hydrogen-instructions.h:135: // HLoadFunctionPrototype >> On 2011/01/26 11:54:00, Kevin Millikin wrote: >>> >>> These are intended to be alphabetized. >> >> Actually do we need this comment at all? It's a PITA to update it and >> nothing enforces that what it says is correct. > > I'll happily delete it :) I don't like it either.
Yay! >> There's DependsOnMaps and no ChangesMaps. We actually discussed this >> with Florian and decided it's nice to have a more precise dependency in >> general. > > Good catch. I will just get rid of kDependsOnMaps too, then. It would be > nice to have finer-grained side effects in some cases, but I don't think we > should add extra depends flags if they don't serve a purpose other than > documentation. The intent is to think in terms of adding fine-grained > changes flags and then marking the things that depend on those changes, > rather than thinking of fine grained depends. When adding fine grained changes flags is there a good way to find the instructions that can use more fine grained depends flags? HLoad- and HStore- instructions are easy to match, but can't there be other cases? -- Vitaly -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
