http://codereview.chromium.org/5990005/diff/29001/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right):
http://codereview.chromium.org/5990005/diff/29001/src/ia32/code-stubs-ia32.cc#newcode5009 src/ia32/code-stubs-ia32.cc:5009: static const int8_t kMovEaxImmediate = static_cast<int8_t>(0xb8); On 2011/01/05 09:59:26, Mads Ager wrote:
Add the 'Byte' suffix to this one as well?
Done. http://codereview.chromium.org/5990005/diff/29001/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/5990005/diff/29001/src/ia32/lithium-codegen-ia32.cc#newcode1811 src/ia32/lithium-codegen-ia32.cc:1811: InstanceofStub stub(flags); On 2011/01/05 09:59:26, Mads Ager wrote:
Can you move this declaration up to where the flags are defined to
make it clear
what they are used for?
Done. http://codereview.chromium.org/5990005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
