Hi Alexandre, do you have a patch ready for your bug fix (regarding StoreNamedField) that you can upload for review?
Regards, Karl 2011/1/4 Søren Gjesse <[email protected]> > Alexandre, > > Thank you for looking int completing the crankshaft ARM port. > > In r6155 the following went in > > DoJSArrayLength > DoLoadNamedField > DoCallConstantFunction > DoBoundsCheck > DoCheckPrototypeMaps > > We will keep from working on the rest you mentioned. > > Regards, > Søren > > On Tue, Jan 4, 2011 at 14:49, Mads Sig Ager <[email protected]> wrote: > >> Hi Alexandre, >> >> please do upload your changes. We have custom expectations for running >> crankshaft on ARM. If you notice a bug, put the failing tests on the >> test list and file a bug report that you assign to yourself. We will >> keep on trucking and things will pick up quickly. If you do not upload >> small changes it will drown and we will duplicate work. >> >> Thanks! -- Mads >> >> On Tue, Jan 4, 2011 at 1:31 PM, Alexandre Rames >> <[email protected]> wrote: >> > Hell everyone, >> > I saw a patch by Karl this morning, where implemented a few ARM Lithium >> > stubs >> > http://codereview.chromium.org/6069010/ >> > I had been working on a few of these too, but I was fixing other bugs >> > discovered and I did not upload them. >> > So that we don't overlap, here is a list of the ARM LCodeGen stubs I >> have >> > implemented over the last few days. >> > DoStoreNamedField >> > DoLoadNamedField >> > DoIsNull >> > DoClassOfTestAndBranch >> > DoCmpMapAndBranch >> > DoCheckPrototypeMaps >> > DoCallConstantFunction >> > DoLoadElements >> > DoArrayLength >> > DoBoundsCheck >> > DoLoadKeyedFastElement >> > DoStoreKeyedFastElement >> > Also I mentioned a bug I found in LCodeGen::DoBranch that appeared when >> both >> > DoLoadNamedField and DoStoreNamedField are implemented. >> > The fix is very simple and we should upload it today. However this does >> not >> > solve all our problems: another (hopefully not too many) bug is hiding >> after >> > this one. >> > I'll start uploading the other stubs when these bugs are fixed. >> > Cheers, >> > Alexandre >> > >> > -- >> > v8-dev mailing list >> > [email protected] >> > http://groups.google.com/group/v8-dev >> >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev >> > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
