You will have to update the classic code generators for ARM and c64, because they use the same code in accessors.cc.
Other than that, LGTM. http://codereview.chromium.org/6116001/diff/8001/src/heap.h File src/heap.h (right): http://codereview.chromium.org/6116001/diff/8001/src/heap.h#newcode119 src/heap.h:119: V(Object, arguments_marker, ArgumentsMarker) I guess this list is unordered, but it makes sense to put all the oddballs together. http://codereview.chromium.org/6116001/diff/8001/src/objects-debug.cc File src/objects-debug.cc (right): http://codereview.chromium.org/6116001/diff/8001/src/objects-debug.cc#newcode371 src/objects-debug.cc:371: ASSERT(value == 0 || value == 1 || value == -1 || This seems a bit silly, but I guess it could catch a corrupted oddball? Maybe add a comment that we use distinct negative integers for ToNumber on 'hidden' oddballs, and then rewrite the assert as: const int kLeastHiddenOddballNumber = -4; ASSERT(value <= 1); ASSERT(value >= kLeastHiddenOddballNumber); http://codereview.chromium.org/6116001/diff/8001/src/objects.h File src/objects.h (right): http://codereview.chromium.org/6116001/diff/8001/src/objects.h#newcode596 src/objects.h:596: INLINE(bool IsArgumentsMarker()); I wonder why we INLINE exactly these two? http://codereview.chromium.org/6116001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
