Actually, looking a bit closer, there's no reason for this function to be in class MaybeObject. I'll move it.
On Fri, Jan 7, 2011 at 8:45 AM, Kevin Millikin <[email protected]>wrote: > On Thu, Jan 6, 2011 at 5:22 PM, <[email protected]> wrote: > >> http://codereview.chromium.org/6116001/diff/8001/src/objects.h#newcode596 >> src/objects.h:596: INLINE(bool IsArgumentsMarker()); >> On 2011/01/06 14:00:47, Kevin Millikin wrote: >> >>> I wonder why we INLINE exactly these two? >>> >> >> Good question. I don't know. Maybe we should use INLINE for the others >> too. >> >> > I'd actually get rid of INLINE instead, unless there's a compelling reason > to have it there. From a naive performance standpoint, it seems like > ToObject and IsFailure are the ones that might need to be forced always > inlined. > > In the old days, gdb used to get pretty confused by > __attribute__((always_inline)), but gdb seems smarter now so it probably > doesn't really matter too much. > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
