LGTM. I like the much nicer safe-point table abstractions!
http://codereview.chromium.org/6125007/diff/1/src/safepoint-table.cc File src/safepoint-table.cc (right): http://codereview.chromium.org/6125007/diff/1/src/safepoint-table.cc#newcode102 src/safepoint-table.cc:102: } Maybe print the number of arguments for the entry if > 0 here. http://codereview.chromium.org/6125007/diff/1/src/safepoint-table.h File src/safepoint-table.h (right): http://codereview.chromium.org/6125007/diff/1/src/safepoint-table.h#newcode93 src/safepoint-table.h:93: kDeoptIndexBits> {}; // NOLINT Is the NO_LINT needed? This looks like perfectly fine style to me. http://codereview.chromium.org/6125007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
