Thanks! Submitted.
-- Vitaly
http://codereview.chromium.org/6125007/diff/1/src/ia32/deoptimizer-ia32.cc
File src/ia32/deoptimizer-ia32.cc (right):
http://codereview.chromium.org/6125007/diff/1/src/ia32/deoptimizer-ia32.cc#newcode58
src/ia32/deoptimizer-ia32.cc:58: unsigned pc_offset =
table.GetPcOffset(i);
On 2011/01/12 10:57:34, Søren Gjesse wrote:
You need to make this change in deoptimizer-arm.cc as well.
Thanks for the reminder. I actually indented to do the port after the
ia32 part is LGTM'ed, but forgot to mention it. Now the port is done.
http://codereview.chromium.org/6125007/diff/1/src/safepoint-table.cc
File src/safepoint-table.cc (right):
http://codereview.chromium.org/6125007/diff/1/src/safepoint-table.cc#newcode102
src/safepoint-table.cc:102: }
On 2011/01/12 09:57:02, fschneider wrote:
Maybe print the number of arguments for the entry if > 0 here.
Good idea. Done.
http://codereview.chromium.org/6125007/diff/1/src/safepoint-table.h
File src/safepoint-table.h (right):
http://codereview.chromium.org/6125007/diff/1/src/safepoint-table.h#newcode93
src/safepoint-table.h:93: kDeoptIndexBits> {}; // NOLINT
On 2011/01/12 09:57:02, fschneider wrote:
Is the NO_LINT needed? This looks like perfectly fine style to me.
Cpplint doesn't like the semicolon after the closing brace, it thinks
this is something like "while (foo) {};".
http://codereview.chromium.org/6125007/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
