Reviewers: Dmitry Titov,
Description:
[Isolates] Make lint happy.
TBR=dimich
Please review this at http://codereview.chromium.org/6196006/
Affected files:
M include/v8.h
M src/isolate.h
M src/scanner-base.h
M src/scanner.h
M test/cctest/test-spaces.cc
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
cdbf769f829f4d28f780cd0242816a2180b34a98..c157dd565bc2787be4737e99f07c913e9da7b432
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -3500,14 +3500,13 @@ class Internals {
return *reinterpret_cast<T*>(addr);
}
- static inline bool CanCastToHeapObject(void*) { return false; }
- static inline bool CanCastToHeapObject(Context*) { return true; }
- static inline bool CanCastToHeapObject(String*) { return true; }
- static inline bool CanCastToHeapObject(Object*) { return true; }
- static inline bool CanCastToHeapObject(Message*) { return true; }
- static inline bool CanCastToHeapObject(StackTrace*) { return true; }
- static inline bool CanCastToHeapObject(StackFrame*) { return true; }
-
+ static inline bool CanCastToHeapObject(void* o) { return false; }
+ static inline bool CanCastToHeapObject(Context* o) { return true; }
+ static inline bool CanCastToHeapObject(String* o) { return true; }
+ static inline bool CanCastToHeapObject(Object* o) { return true; }
+ static inline bool CanCastToHeapObject(Message* o) { return true; }
+ static inline bool CanCastToHeapObject(StackTrace* o) { return true; }
+ static inline bool CanCastToHeapObject(StackFrame* o) { return true; }
};
} // namespace internal
@@ -3527,8 +3526,8 @@ Local<T> Local<T>::New(Handle<T> that) {
T* that_ptr = *that;
internal::Object** p = reinterpret_cast<internal::Object**>(that_ptr);
if (internal::Internals::CanCastToHeapObject(that_ptr)) {
- return Local<T>(reinterpret_cast<T*>(
-
HandleScope::CreateHandle(reinterpret_cast<internal::HeapObject*>(*p))));
+ return Local<T>(reinterpret_cast<T*>(HandleScope::CreateHandle(
+ reinterpret_cast<internal::HeapObject*>(*p))));
}
return Local<T>(reinterpret_cast<T*>(HandleScope::CreateHandle(*p)));
}
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index
77af872b3f600650e05058e5657edc81734d86c6..055ce558dbd18453ca2f55da3b0504cc58184b52
100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -1156,7 +1156,7 @@ class StackLimitCheck BASE_EMBEDDED {
// account.
class PostponeInterruptsScope BASE_EMBEDDED {
public:
- PostponeInterruptsScope(Isolate* isolate)
+ explicit PostponeInterruptsScope(Isolate* isolate)
: stack_guard_(isolate->stack_guard()) {
stack_guard_->thread_local_.postpone_interrupts_nesting_++;
stack_guard_->DisableInterrupts();
Index: src/scanner-base.h
diff --git a/src/scanner-base.h b/src/scanner-base.h
index
c75a22ed26e0f0674a65d7a26a5e2ba44dd6d58f..e947f25f1478d2da242bdb25024b468dc577fae4
100644
--- a/src/scanner-base.h
+++ b/src/scanner-base.h
@@ -370,7 +370,7 @@ class JavaScriptScanner : public Scanner {
bool complete_;
};
- JavaScriptScanner(ScannerConstants* scanner_constants);
+ explicit JavaScriptScanner(ScannerConstants* scanner_constants);
// Returns the next token.
Token::Value Next();
Index: src/scanner.h
diff --git a/src/scanner.h b/src/scanner.h
index
51cf8d2217b55aaf0b2538586be3bca9359e3095..d33b098253e4a183c2fa95b796b576b3a7352c4f
100644
--- a/src/scanner.h
+++ b/src/scanner.h
@@ -103,7 +103,7 @@ class StreamInitializer {
class V8JavaScriptScanner : public JavaScriptScanner {
public:
- V8JavaScriptScanner(Isolate* isolate)
+ explicit V8JavaScriptScanner(Isolate* isolate)
: JavaScriptScanner(isolate->scanner_constants()) {}
// Initialize the Scanner to scan source.
Index: test/cctest/test-spaces.cc
diff --git a/test/cctest/test-spaces.cc b/test/cctest/test-spaces.cc
index
2ca0ee3e8b3ef3e271ee861812308870aa80c8d9..051af2f2f96cbae7b1670864568f2769e679d29d
100644
--- a/test/cctest/test-spaces.cc
+++ b/test/cctest/test-spaces.cc
@@ -158,8 +158,8 @@ TEST(MemoryAllocator) {
TEST(NewSpace) {
OS::Setup();
CHECK(HEAP->ConfigureHeapDefault());
- CHECK(Isolate::Current()->memory_allocator()->Setup(HEAP->MaxReserved(),
-
HEAP->MaxExecutableSize()));
+ CHECK(Isolate::Current()->memory_allocator()->Setup(
+ HEAP->MaxReserved(), HEAP->MaxExecutableSize()));
NewSpace new_space(HEAP);
@@ -186,8 +186,8 @@ TEST(NewSpace) {
TEST(OldSpace) {
OS::Setup();
CHECK(HEAP->ConfigureHeapDefault());
- CHECK(Isolate::Current()->memory_allocator()->Setup(HEAP->MaxReserved(),
-
HEAP->MaxExecutableSize()));
+ CHECK(Isolate::Current()->memory_allocator()->Setup(
+ HEAP->MaxReserved(), HEAP->MaxExecutableSize()));
OldSpace* s = new OldSpace(HEAP,
HEAP->MaxOldGenerationSize(),
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
