Revision: 6289
Author: [email protected]
Date: Wed Jan 12 08:46:47 2011
Log: [Isolates] Make lint happy.
TBR=dimich
Review URL: http://codereview.chromium.org/6196006
http://code.google.com/p/v8/source/detail?r=6289
Modified:
/branches/experimental/isolates/include/v8.h
/branches/experimental/isolates/src/isolate.h
/branches/experimental/isolates/src/scanner-base.h
/branches/experimental/isolates/src/scanner.h
/branches/experimental/isolates/test/cctest/test-spaces.cc
=======================================
--- /branches/experimental/isolates/include/v8.h Mon Dec 13 19:40:56 2010
+++ /branches/experimental/isolates/include/v8.h Wed Jan 12 08:46:47 2011
@@ -3500,14 +3500,13 @@
return *reinterpret_cast<T*>(addr);
}
- static inline bool CanCastToHeapObject(void*) { return false; }
- static inline bool CanCastToHeapObject(Context*) { return true; }
- static inline bool CanCastToHeapObject(String*) { return true; }
- static inline bool CanCastToHeapObject(Object*) { return true; }
- static inline bool CanCastToHeapObject(Message*) { return true; }
- static inline bool CanCastToHeapObject(StackTrace*) { return true; }
- static inline bool CanCastToHeapObject(StackFrame*) { return true; }
-
+ static inline bool CanCastToHeapObject(void* o) { return false; }
+ static inline bool CanCastToHeapObject(Context* o) { return true; }
+ static inline bool CanCastToHeapObject(String* o) { return true; }
+ static inline bool CanCastToHeapObject(Object* o) { return true; }
+ static inline bool CanCastToHeapObject(Message* o) { return true; }
+ static inline bool CanCastToHeapObject(StackTrace* o) { return true; }
+ static inline bool CanCastToHeapObject(StackFrame* o) { return true; }
};
} // namespace internal
@@ -3527,8 +3526,8 @@
T* that_ptr = *that;
internal::Object** p = reinterpret_cast<internal::Object**>(that_ptr);
if (internal::Internals::CanCastToHeapObject(that_ptr)) {
- return Local<T>(reinterpret_cast<T*>(
-
HandleScope::CreateHandle(reinterpret_cast<internal::HeapObject*>(*p))));
+ return Local<T>(reinterpret_cast<T*>(HandleScope::CreateHandle(
+ reinterpret_cast<internal::HeapObject*>(*p))));
}
return Local<T>(reinterpret_cast<T*>(HandleScope::CreateHandle(*p)));
}
=======================================
--- /branches/experimental/isolates/src/isolate.h Mon Dec 13 19:40:56 2010
+++ /branches/experimental/isolates/src/isolate.h Wed Jan 12 08:46:47 2011
@@ -1156,7 +1156,7 @@
// account.
class PostponeInterruptsScope BASE_EMBEDDED {
public:
- PostponeInterruptsScope(Isolate* isolate)
+ explicit PostponeInterruptsScope(Isolate* isolate)
: stack_guard_(isolate->stack_guard()) {
stack_guard_->thread_local_.postpone_interrupts_nesting_++;
stack_guard_->DisableInterrupts();
=======================================
--- /branches/experimental/isolates/src/scanner-base.h Mon Dec 13 19:40:56
2010
+++ /branches/experimental/isolates/src/scanner-base.h Wed Jan 12 08:46:47
2011
@@ -370,7 +370,7 @@
bool complete_;
};
- JavaScriptScanner(ScannerConstants* scanner_constants);
+ explicit JavaScriptScanner(ScannerConstants* scanner_constants);
// Returns the next token.
Token::Value Next();
=======================================
--- /branches/experimental/isolates/src/scanner.h Mon Dec 13 19:40:56 2010
+++ /branches/experimental/isolates/src/scanner.h Wed Jan 12 08:46:47 2011
@@ -103,7 +103,7 @@
class V8JavaScriptScanner : public JavaScriptScanner {
public:
- V8JavaScriptScanner(Isolate* isolate)
+ explicit V8JavaScriptScanner(Isolate* isolate)
: JavaScriptScanner(isolate->scanner_constants()) {}
// Initialize the Scanner to scan source.
=======================================
--- /branches/experimental/isolates/test/cctest/test-spaces.cc Mon Dec 13
19:40:56 2010
+++ /branches/experimental/isolates/test/cctest/test-spaces.cc Wed Jan 12
08:46:47 2011
@@ -158,8 +158,8 @@
TEST(NewSpace) {
OS::Setup();
CHECK(HEAP->ConfigureHeapDefault());
- CHECK(Isolate::Current()->memory_allocator()->Setup(HEAP->MaxReserved(),
-
HEAP->MaxExecutableSize()));
+ CHECK(Isolate::Current()->memory_allocator()->Setup(
+ HEAP->MaxReserved(), HEAP->MaxExecutableSize()));
NewSpace new_space(HEAP);
@@ -186,8 +186,8 @@
TEST(OldSpace) {
OS::Setup();
CHECK(HEAP->ConfigureHeapDefault());
- CHECK(Isolate::Current()->memory_allocator()->Setup(HEAP->MaxReserved(),
-
HEAP->MaxExecutableSize()));
+ CHECK(Isolate::Current()->memory_allocator()->Setup(
+ HEAP->MaxReserved(), HEAP->MaxExecutableSize()));
OldSpace* s = new OldSpace(HEAP,
HEAP->MaxOldGenerationSize(),
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
