Drive by suggestion.
http://codereview.chromium.org/6237002/diff/1/src/ia32/lithium-ia32.h File src/ia32/lithium-ia32.h (right): http://codereview.chromium.org/6237002/diff/1/src/ia32/lithium-ia32.h#newcode533 src/ia32/lithium-ia32.h:533: this->SetInputAt(0, left); We could have a convenience function SetInputs(inputs...) defined for up to certain number of input operands, so that in all instruction subclasses we could write: LSubclass(LOperand* op1, ..., LOperand* opN) { this->SetInputs(op1, ..., opN); } This could also be done for temps. http://codereview.chromium.org/6237002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
