LGTM, but the function is not used anywhere.
http://codereview.chromium.org/6301001/diff/1/src/debug-debugger.js File src/debug-debugger.js (right): http://codereview.chromium.org/6301001/diff/1/src/debug-debugger.js#newcode653 src/debug-debugger.js:653: Debug.setBreakPointByScriptIdAndPosition = function(script_id, position, condition, enabled) Please avoid long lines even though the .js files are not linted. http://codereview.chromium.org/6301001/diff/1/src/debug-debugger.js#newcode658 src/debug-debugger.js:658: break_point.disable(); Only 2 space indent or same line. http://codereview.chromium.org/6301001/diff/1/src/debug-debugger.js#newcode662 src/debug-debugger.js:662: break_point.actual_position = %SetScriptBreakPoint(scripts[i], position, break_point); Ditto. http://codereview.chromium.org/6301001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
