Thanks Pavel, But could you please put in a V8 test as well, as we don't want catching issues with this in layout tests.
Regards, Søren On Fri, Jan 14, 2011 at 10:57, Pavel Podivilov <[email protected]> wrote: > Sure, DevTools would set breakpoints using this function so it would > definitely be tested by layout tests. > > BR, > Pavel Podivilov > > > > On Thu, Jan 13, 2011 at 11:40 PM, Søren Gjesse <[email protected]>wrote: > >> OK, will this be tested in some of the DevTools tests? Otherwise this >> might get broken without anybody noticing. >> >> /Søren >> >> >> On Thu, Jan 13, 2011 at 18:32, <[email protected]> wrote: >> >>> On 2011/01/13 15:46:14, Søren Gjesse wrote: >>> >>>> LGTM, but the function is not used anywhere. >>>> >>> >>> It will be used from WebCore DebuggerScript.js >>> >>> >>> http://codereview.chromium.org/6301001/ >>> >> >> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
