http://codereview.chromium.org/6351007/diff/1/src/d8.js File src/d8.js (right):
http://codereview.chromium.org/6351007/diff/1/src/d8.js#newcode592 src/d8.js:592: // Remember the handle requested in a global variable. Maybe change handle to id here to keep the distinction between # and @ numbers. http://codereview.chromium.org/6351007/diff/1/src/debug-debugger.js File src/debug-debugger.js (right): http://codereview.chromium.org/6351007/diff/1/src/debug-debugger.js#newcode2053 src/debug-debugger.js:2053: response.body = MakeMirror(%GetLOLObj(obj_id)); I think we should be able to unify the handles ids used by the debugger and the object ids used in lols. What do you think about this: If lol is enabled then the debugger should just use the lol id instead of generating its own handle id. That will make the ids persistent between debugger invocations as long as lol is activated. That way we don't need both the @ and the # ids. This unification can be done in a separate change it it can work. http://codereview.chromium.org/6351007/diff/1/src/debug-debugger.js#newcode2387 src/debug-debugger.js:2387: DebugCommandProcessor.prototype.lolCaptureRequest_ = function(request, response) { We try to split the long lines when possible, e.g. JSONProtocolSerializer.prototype.serializeReferenceWithDisplayData_ and JSONProtocolSerializer.prototype.serialize_ in mirror-debugger.js http://codereview.chromium.org/6351007/diff/1/src/debug-debugger.js#newcode2392 src/debug-debugger.js:2392: DebugCommandProcessor.prototype.lolDeleteRequest_ = function(request, response) { Ditto. http://codereview.chromium.org/6351007/diff/1/src/debug-debugger.js#newcode2437 src/debug-debugger.js:2437: DebugCommandProcessor.prototype.lolRetainersRequest_ = function(request, response) { Ditto. http://codereview.chromium.org/6351007/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/6351007/diff/1/src/runtime.cc#newcode45 src/runtime.cc:45: #include "liveobjectlist.h" This suggests that the actual lol implementation lands before this change. Or should we have an "empty" class LiveObjectList in liveobjects.h added to this change? http://codereview.chromium.org/6351007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
