I've addressed Søren's comments below, and would like to defer the requested
changes as part of the debugger/runtime vs lol core isolation that I'll
submit
in a later CL.
The only change in the code since last time is the #include of
liveobjectlist-inl.h instead of liveobjectlist.h.
Please take a look. Thanks.
http://codereview.chromium.org/6351007/diff/9001/src/runtime.cc
File src/runtime.cc (right):
http://codereview.chromium.org/6351007/diff/9001/src/runtime.cc#newcode10479
src/runtime.cc:10479: // Captures a live object list from the present
heap.
On 2011/01/25 12:44:15, Søren Gjesse wrote:
With the stubbed-out implementation of LiveObjectList I don't think we
need
#ifdef/#else/#endif in here anymore.
I was hoping to not incur any footprint at all for code space (though
admittedly tiny) when lol is not built in. In the functions below this
one, there is code needed for marshalling args as well that is not
removed by current stubbed implementations.
If it's ok, I can move all the code out of here into another module
later when I do the separation of core lol code from the lol
debugger/runtime interfaces. That would be a natural time to abstract
these out.
http://codereview.chromium.org/6351007/diff/9001/src/runtime.cc#newcode10481
src/runtime.cc:10481: #ifdef LIVE_OBJECT_LIST
On 2011/01/25 12:44:15, Søren Gjesse wrote:
How about adding LiveObjectList::Enabled() returning
Heap::false_value() in the
empty implementation?
Same as above (for consistency).
http://codereview.chromium.org/6351007/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
