http://codereview.chromium.org/6338009/diff/1/SConstruct
File SConstruct (right):

http://codereview.chromium.org/6338009/diff/1/SConstruct#newcode132
SConstruct:132: 'CPPDEFINES':   ['ENABLE_DEBUGGER_SUPPORT', 'INSPECTOR',
'LIVE_OBJECT_LIST', 'OBJECT_PRINT'],
Split long line.

Do you want to always enable OBJECT_PRINT and INSPECTOR when enabling
lol?

http://codereview.chromium.org/6338009/diff/1/SConstruct#newcode1020
SConstruct:1020:
Maybe add a warning here if liveobjectlist is on and debuggersupport is
off saying that debuggersupport will be forced on by enabling
liveobjectlist - or maybe that is just a wast of time.

http://codereview.chromium.org/6338009/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

http://codereview.chromium.org/6338009/diff/1/tools/gyp/v8.gyp#newcode445
tools/gyp/v8.gyp:445: '../../src/liveedit.h',
Please add '../../src/liveobjectlist-inl.h' here as well.

http://codereview.chromium.org/6338009/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to