I've addressed the issues, but for some reason, my gcl configuration is
messed
up, and I was not able to upload the updated files. So, I cleaned it and
uploaded a separate CL at:
http://codereview.chromium.org/6364002
http://codereview.chromium.org/6338009/diff/1/SConstruct
File SConstruct (right):
http://codereview.chromium.org/6338009/diff/1/SConstruct#newcode132
SConstruct:132: 'CPPDEFINES': ['ENABLE_DEBUGGER_SUPPORT', 'INSPECTOR',
'LIVE_OBJECT_LIST', 'OBJECT_PRINT'],
On 2011/01/19 09:09:47, Søren Gjesse wrote:
Split long line.
Do you want to always enable OBJECT_PRINT and INSPECTOR when enabling
lol?
Done. Yes, I want it ti always enable INSPECTOR and OBJECT_PRINT
defined whenever lol is enabled.
http://codereview.chromium.org/6338009/diff/1/SConstruct#newcode1020
SConstruct:1020:
On 2011/01/19 09:09:47, Søren Gjesse wrote:
Maybe add a warning here if liveobjectlist is on and debuggersupport
is off
saying that debuggersupport will be forced on by enabling
liveobjectlist - or
maybe that is just a wast of time.
Done.
http://codereview.chromium.org/6338009/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
http://codereview.chromium.org/6338009/diff/1/tools/gyp/v8.gyp#newcode445
tools/gyp/v8.gyp:445: '../../src/liveedit.h',
On 2011/01/19 09:09:47, Søren Gjesse wrote:
Please add '../../src/liveobjectlist-inl.h' here as well.
Done.
http://codereview.chromium.org/6338009/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
